Skip to content

HBASE-29368: Key management for encryption at rest (phase 1 and 2 changes) #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

HBASE-29368: Key management for encryption at rest (phase 1 and 2 changes) #7421

wants to merge 15 commits into from
+11,704 −420

Conversation

@haridsv
Copy link
Contributor

@haridsv haridsv commented Oct 29, 2025 •
edited
Loading

haridsv and others added 12 commits August 5, 2025 14:03
@haridsv
HBASE-29402: Comprehensive key management for encryption at rest (#7111)
211132c
@virajjasani
Merge branch 'master' into HBASE-29368-key-management-feature
ece4719
@virajjasani
Merge branch 'master' of github.com:apache/hbase into HBASE-29368-key…
3795b39 
…-management-feature
@virajjasani
Merge branch 'master' into HBASE-29368-key-management-feature
741199d
@haridsv
Fix compilation error in HBASE-29368 feature branch (#7298)
281dc16
@virajjasani
Merge branch 'master' into HBASE-29368-key-management-feature
552e072
@virajjasani @haridsv
spotless fixes
d6da6fd 
Co-authored-by: Hari Dara <[email protected]>
@haridsv
HBASE-29495: Integrate key management with existing encryption (#7297)
4d4d167
@virajjasani
Merge branch 'master' of github.com:apache/hbase into HBASE-29368-key…
4349e69 
…-management-feature
@haridsv
HBASE-29617: Changes to support smooth migration to key management (#…
bad5c8f 
…7362)
@virajjasani
Merge branch 'master' into HBASE-29368-key-management-feature
4e73e8a
@haridsv
HBASE-29643: Admin API to trigger for System Key rotation (#7394)
020adaa
@Apache-HBase

This comment has been minimized.

Sign in to view
haridsv added a commit to haridsv/hbase that referenced this pull request Oct 30, 2025
@haridsv
Fix misc. issues flagged in PR validation build of apache#7421
3e6018e
@haridsv
Copy link
Contributor Author

haridsv commented Oct 30, 2025

Fixing misc. issues flagged in the PR validation build via PR #7423

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@haridsv haridsv mentioned this pull request Nov 3, 2025
Merged
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

Apache-HBase commented Nov 5, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 yamllint 0m 0s yamllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 3m 32s master passed
+1 💚 compile 8m 34s master passed
+1 💚 checkstyle 2m 23s master passed
+1 💚 spotbugs 14m 57s master passed
+1 💚 spotless 0m 48s branch has no errors when running spotless:check.
-0 ⚠️ patch 1m 41s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 11s the patch passed
+1 💚 compile 8m 34s the patch passed
+1 💚 cc 8m 34s the patch passed
-0 ⚠️ javac 8m 34s /results-compile-javac-root.txt root generated 3 new + 1895 unchanged - 1 fixed = 1898 total (was 1896)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 2m 19s /results-checkstyle-root.txt root: The patch generated 1 new + 103 unchanged - 0 fixed = 104 total (was 103)
-0 ⚠️ rubocop 0m 37s /results-rubocop.txt The patch generated 20 new + 488 unchanged - 17 fixed = 508 total (was 505)
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 15m 57s the patch passed
+1 💚 hadoopcheck 12m 31s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 hbaseprotoc 5m 41s the patch passed
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 1m 20s The patch does not generate ASF License warnings.
92m 9s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7421/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7421
JIRA Issue HBASE-29368
Optional Tests dupname asflicense codespell detsecrets spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti cc buflint bufcompat hbaseprotoc xmllint rubocop yamllint
uname Linux 0d42a41b26d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c22e111
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 187 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-procedure hbase-server hbase-testing-util hbase-thrift hbase-shell . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7421/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 5, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 5m 8s master passed
+1 💚 compile 3m 33s master passed
+1 💚 javadoc 6m 32s master passed
+1 💚 shadedjars 8m 49s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ patch 9m 59s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 9s the patch passed
+1 💚 compile 3m 17s the patch passed
+1 💚 javac 3m 17s the patch passed
-0 ⚠️ javadoc 0m 40s /results-javadoc-javadoc-hbase-server.txt hbase-server generated 2 new + 63 unchanged - 0 fixed = 65 total (was 63)
-0 ⚠️ javadoc 3m 5s /results-javadoc-javadoc-root.txt root generated 2 new + 210 unchanged - 0 fixed = 212 total (was 210)
+1 💚 shadedjars 8m 17s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 297m 27s /patch-unit-root.txt root in the patch failed.
356m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7421/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7421
JIRA Issue HBASE-29368
Optional Tests javac javadoc unit compile shadedjars
uname Linux 2eef51d875cc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c22e111
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7421/4/testReport/
Max. process+thread count 8210 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-procedure hbase-server hbase-testing-util hbase-thrift hbase-shell . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7421/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@haridsv haridsv marked this pull request as ready for review November 10, 2025 13:48
@haridsv haridsv mentioned this pull request Nov 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haridsv @Apache-HBase @virajjasani